Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update time combo sample #6736

Merged
merged 1 commit into from
Nov 13, 2019
Merged

Update time combo sample #6736

merged 1 commit into from
Nov 13, 2019

Conversation

kurkle
Copy link
Member

@kurkle kurkle commented Nov 12, 2019

The beef is offset: true.

master (chartjs.org master, does not seem to be up to date):
image

pr:
image

Closes: #6535

benmccann
benmccann approved these changes Nov 13, 2019
View reviewed changes
Copy link
Contributor

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Though I feel like you shouldn't have to set unit: 'day'

@etimberg etimberg merged commit fef2a13 into chartjs:master Nov 13, 2019
@etimberg etimberg added this to the Version 3.0 milestone Nov 13, 2019
@kurkle kurkle deleted the time-combo branch November 13, 2019 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etimberg etimberg etimberg approved these changes

@benmccann benmccann benmccann approved these changes

Assignees
No one assigned
Labels
type: documentation
Projects
None yet
Milestone
Version 3.0
Development

Successfully merging this pull request may close these issues.

Mixed chart with time scale does not show all dataset of first and last data
3 participants
@kurkle @benmccann @etimberg